[
https://issues.apache.org/jira/browse/ARTEMIS-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669521#comment-16669521
]
ASF GitHub Bot commented on ARTEMIS-2158:
-----------------------------------------
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2405
ARTEMIS-2158 don't get pagedMessage if it's nontransactional
Transaction id of the non transactional paged message is -1. When we
acknowledge the message, we judge transactionID < 0 and get paged message. The
page where message resides maybe retrieved causing performance degradation. So
we only need to get paged message if transactionID < -1 instead of 0.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wy96f/activemq-artemis
default_page_reference_transaction_id
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2405.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2405
----
commit e024efcccde28ec6ad863cc4d1ad1df7e105905c
Author: yang wei <wy96fyw@...>
Date: 2018-10-31T02:02:11Z
ARTEMIS-2158 don't get pagedMessage if it's nontransactional
----
> don't get pagedMessage if it's nontransactional
> ------------------------------------------------
>
> Key: ARTEMIS-2158
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2158
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Reporter: yangwei
> Priority: Major
>
> Transaction id of the non transactional paged message is -1. When we
> acknowledge the message, we judge transactionID < 0 and get paged message.
> The page where message resides maybe retrieved causing performance
> degradation. So we only need to get paged message if transactionID < -1
> instead of 0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
