[
https://issues.apache.org/jira/browse/ARTEMIS-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672073#comment-16672073
]
ASF GitHub Bot commented on ARTEMIS-2159:
-----------------------------------------
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2409
ARTEMIS-2159 Fixing OpenWire Blocker Producer
Previous change on Flow control in OpenWire broke Blocked cases
This is a better fix.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-2159
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2409.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2409
----
commit a6359d2ada1f880bf9ed537bab812d9a06fb0bfa
Author: Clebert Suconic <clebertsuconic@...>
Date: 2018-11-01T19:33:03Z
ARTEMIS-2159 Fixing OpenWire Blocker Producer
Previous change on Flow control in OpenWire broke Blocked cases
This is a better fix.
----
> OpenWire will allow one extra message to be sent after address is full
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-2159
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2159
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.6.3
> Reporter: clebert suconic
> Assignee: clebert suconic
> Priority: Major
> Fix For: 2.7.0, 2.6.4
>
>
> OpenWire will do a check on isAddressFull with a callback to send the message.
>
> As soon as the address clears one extra message is received, even when the
> client received an exception on sending.
>
>
> We shoulnd't do the send on a callback.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
