[
https://issues.apache.org/jira/browse/ARTEMIS-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679816#comment-16679816
]
ASF GitHub Bot commented on ARTEMIS-2142:
-----------------------------------------
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2387#discussion_r231901536
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -289,6 +289,12 @@ public SimpleString getGroupID() {
return this.getSimpleStringProperty(Message.HDR_GROUP_ID);
}
+ @Override
+ public int getGroupSequence() {
+ final Integer integer =
this.getIntProperty(Message.HDR_GROUP_SEQUENCE);
--- End diff --
This just blew up for me. It is not Mike's bug per se, it just possibly
sends execution to this little function which cannot handle `null`s
https://github.com/apache/activemq-artemis/blob/10ecb358cb587c8417deeb799723d8274b0a44a5/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java#L211-L214
In my JVM,
```
public static Integer valueOf(String var0) throws NumberFormatException
{
return parseInt(var0, 10);
}
```
and
```
public static int parseInt(String var0, int var1) throws
NumberFormatException {
if (var0 == null) {
throw new NumberFormatException("null");
```
Here is a failing test (from cli-java project) on travis ci,
https://travis-ci.org/rh-messaging/cli-java/jobs/451880325 at around
> 13:28:41,911 ERROR Error while sending a message!
> java.lang.NumberFormatException: null
It was not supposed to fetch a 2.7.0 snapshot of artemis-cli-java, but
somehow it did... mystery for the next time, for me or @michalxo.
> Support JMSXGroupSeq -1 to close/reset Groups
> ---------------------------------------------
>
> Key: ARTEMIS-2142
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2142
> Project: ActiveMQ Artemis
> Issue Type: Sub-task
> Reporter: Michael Andre Pearce
> Assignee: Michael Andre Pearce
> Priority: Major
>
> Support Closing groups as per ActiveMQ 5 ,
> [http://activemq.apache.org/message-groups.html] using -1 on groupsequence to
> as the signal
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
