[ 
https://issues.apache.org/jira/browse/ARTEMIS-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686858#comment-16686858
 ] 

ASF GitHub Bot commented on ARTEMIS-2163:
-----------------------------------------

Github user ehsavoie commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2416#discussion_r233531108
  
    --- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java
 ---
    @@ -982,7 +982,13 @@ protected ConnectorFactory 
instantiateConnectorFactory(final String connectorFac
           return AccessController.doPrivileged(new 
PrivilegedAction<ConnectorFactory>() {
              @Override
              public ConnectorFactory run() {
    -            return (ConnectorFactory) 
ClassloadingUtil.newInstanceFromClassLoader(connectorFactoryClassName);
    +            ClassLoader cl = 
Thread.currentThread().getContextClassLoader();
    --- End diff --
    
    No problem there



> Classloading issue if artemis-commons is not in ther same classloader as 
> artemis-client-* or artemis-server
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2163
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2163
>             Project: ActiveMQ Artemis
>          Issue Type: Wish
>          Components: Broker
>    Affects Versions: 2.6.3
>            Reporter: Emmanuel Hugonnet
>            Priority: Major
>
> The class org.apache.activemq.artemis.utils.ClassLoadingUtil is defined in 
> artemis-commons. In a jboss-modules environment this creates a loop to be 
> able to load classes from another module.
> Setting the ThreadContext classloader to the calling class before invoking 
> ClassLoadingUtil
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to