[ 
https://issues.apache.org/jira/browse/ARTEMIS-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688149#comment-16688149
 ] 

ASF GitHub Bot commented on ARTEMIS-2176:
-----------------------------------------

Github user spyrkob commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2432#discussion_r233862871
  
    --- Diff: 
artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java
 ---
    @@ -45,16 +45,41 @@
        private final Map<String, String> properties;
        private final ClientProtocolManagerFactory clientProtocolManager;
     
    +   // ServerLocator properties
    --- End diff --
    
    @clebertsuconic I was trying to make them available in 
createServerLocator() so that I can apply them to new instances of 
ServerLocator. Would it be better to hold a reference to original 
locator/factory instead? Or is there a better way to pass those properties I 
missed?


> RA connection properties are not propagated to XARecoveryConfig
> ---------------------------------------------------------------
>
>                 Key: ARTEMIS-2176
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2176
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.6.3
>            Reporter: Bartosz Spyrko-Smietanko
>            Priority: Major
>
> XARecoveryConfig#createServerLocator uses only 
> TransportConfiguration/DiscoveryGroupConfiguration to create a new instance 
> of ServerLocator. That means that connection properties like connectionTTL or 
> callFailoverTime are ignored.  This can lead to network issues - eg. 
> [https://issues.jboss.org/browse/WFLY-10725] 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to