[
https://issues.apache.org/jira/browse/ARTEMIS-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700486#comment-16700486
]
ASF GitHub Bot commented on ARTEMIS-2186:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2444#discussion_r236681572
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java
---
@@ -1018,6 +1018,7 @@ private void sendContinuations(final int packetSize,
currentLargeMessage.addBytes(body);
if (!continues) {
+ currentLargeMessage.sync();
currentLargeMessage.releaseResources();
--- End diff --
wouldn't releaseResources make a sync when the file is closed?
> Large message incomplete when server is crashed
> -----------------------------------------------
>
> Key: ARTEMIS-2186
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2186
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Reporter: yangwei
> Priority: Major
>
> When sending large message, the large message file on server side is not
> synced whereas the journal record or paged message is synced.
> When server crashes, large message file maybe incomplete.
> In our case, we saw an empty file when server crashed and started. Then a
> large message with zero size body was delivered to client, client occured
> exception:
> AMQ212058: Unable to get a message.: java.lang.IndexOutOfBoundsException:
> readerIndex(4) + length(1) exceeds writerIndex(4):
> UnpooledDuplicatedByteBuf(ridx: 4, widx: 4, cap: 4, unwrapped:
> UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeHeapByteBuf(ridx: 4, widx:
> 4, cap: 4))@ClientLargeMessageImpl
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
