[ 
https://issues.apache.org/jira/browse/ARTEMIS-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711570#comment-16711570
 ] 

ASF GitHub Bot commented on ARTEMIS-1867:
-----------------------------------------

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2434#discussion_r239488173
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java
 ---
    @@ -53,7 +54,13 @@
     
        private final Map<SimpleString, Integer> routingNamePositions = new 
ConcurrentHashMap<>();
     
    -   private final Map<Long, Binding> bindingsMap = new 
ConcurrentHashMap<>();
    +   private final Map<Long, Binding> bindingsIdMap = new 
ConcurrentHashMap<>();
    +
    +   /**
    +    * This is the same as bindingsIdMap but indexed on the binding's 
uniqueName rather than ID. Two maps are
    +    * maintained to speed routing, otherwise we'd have to loop through the 
bindingsIdMap when routing to an FQQN.
    +    */
    +   private final Map<SimpleString, Binding> bindingsNameMap = new 
ConcurrentHashMap<>();
    --- End diff --
    
    I'm not aware of the context here, but  considering that are used 2 
different concurrent maps I suppose that there is no chance that data would be 
different between them from a reader pov right?
    If not I suppose that's fine


> Support FQQN for producers
> --------------------------
>
>                 Key: ARTEMIS-1867
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1867
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: STOMP
>            Reporter: Justin Bertram
>            Priority: Major
>
> Allow STOMP clients to send messages directly to a fully-qualified queue 
> rather than just an address.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to