[
https://issues.apache.org/jira/browse/ARTEMIS-2222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738654#comment-16738654
]
ASF GitHub Bot commented on ARTEMIS-2222:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2492#discussion_r246538095
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
---
@@ -1315,9 +1315,7 @@ private PagedReference moveNext() {
}
}
- if (!ignored) {
- position = message.getPosition();
- }
+ position = message.getPosition();
--- End diff --
I think this made sense at some point, but after a few fixes later it's
harmless.
I don't think this needs a JIRA as there's no issue I think.
I will merge and keep the JIRA, but I will rename the commit from being a
question into something more affirmative.
> why the position remains unchanged if ignored is set to true
> ------------------------------------------------------------
>
> Key: ARTEMIS-2222
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2222
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: yuebao
> Priority: Major
>
> I am a bit confused about this, When CursorIterator:next is called during
> queue depage, if ignored is set to true, why the position remains unchanged.
> if (!ignored) {
> position = message.getPosition();
> }
> For example, the client sends some messages to the topic subscriber ta (this
> topic has two subscribers ta and tb), every time tb depage continuous
> PagePositions that ignored are set to true will be traversed again.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
