[ 
https://issues.apache.org/jira/browse/ARTEMIS-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738684#comment-16738684
 ] 

ASF GitHub Bot commented on ARTEMIS-2224:
-----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2494#discussion_r246558406
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/LivePageCacheImpl.java
 ---
    @@ -28,15 +28,49 @@
     /**
      * This is the same as PageCache, however this is for the page that's 
being currently written.
      */
    --- End diff --
    
    Isn't this mixing the collection implementation itself into the 
LivePageCache?
    
    isn't there a way to implement this logic into its own structure? Like 
PageCache using a generic ChunkArray (a name I just came up here)?
    
    I'm a bit concerned on maintaining the business side of this issue (that is 
the PageCache) with the speedy implementation of a collection.


> Reduce contention on LivePageCacheImpl
> --------------------------------------
>
>                 Key: ARTEMIS-2224
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2224
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.7.0
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Major
>
> Has been measured that LIvePageCacheImpl operations are a source of 
> contention on producer side while paging. 
> This contention decrease the scalability of the broker in an evident way 
> while using topics, because the page cache is been accessed concurrently by 
> several producers to ack transactions while the messages are being appended.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to