[ 
https://issues.apache.org/jira/browse/ARTEMIS-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738863#comment-16738863
 ] 

ASF GitHub Bot commented on ARTEMIS-2224:
-----------------------------------------

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2494#discussion_r246602226
  
    --- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentAppendOnlyChunkedList.java
 ---
    @@ -0,0 +1,291 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.utils.collections;
    +
    +import java.util.Objects;
    +import java.util.concurrent.atomic.AtomicLongFieldUpdater;
    +import java.util.concurrent.atomic.AtomicReferenceArray;
    +import java.util.function.IntFunction;
    +
    +/**
    + * This collection is a concurrent append-only list that grows in 
chunks.<br>
    + * It's safe to be used by many threads concurrently and has a max 
capacity of {@link Integer#MAX_VALUE}.
    + */
    +public final class ConcurrentAppendOnlyChunkedList<T> {
    --- End diff --
    
    Thanks to you guys and one day I will be better in naming things too I 
swear :D


> Reduce contention on LivePageCacheImpl
> --------------------------------------
>
>                 Key: ARTEMIS-2224
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2224
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.7.0
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Major
>
> Has been measured that LIvePageCacheImpl operations are a source of 
> contention on producer side while paging. 
> This contention decrease the scalability of the broker in an evident way 
> while using topics, because the page cache is been accessed concurrently by 
> several producers to ack transactions while the messages are being appended.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to