[
https://issues.apache.org/jira/browse/ARTEMIS-2228?focusedWorklogId=185161&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185161
]
ASF GitHub Bot logged work on ARTEMIS-2228:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jan/19 07:06
Start Date: 15/Jan/19 07:06
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2498:
ARTEMIS-2228 Large Messages over Management
URL: https://github.com/apache/activemq-artemis/pull/2498#discussion_r247781204
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
##########
@@ -1005,9 +1006,9 @@ public RemotingConnection getRemotingConnection() {
ByteBuffer buffer = ByteBuffer.allocate(8);
buffer.putLong(queue.getID());
message.putBytesProperty(Message.HDR_ROUTE_TO_IDS, buffer.array());
- postOffice.route(message, true);
+
server.getPostOffice().route(LargeServerMessageImpl.checkLargeMessage(message,
server.getStorageManager()), true);
Review comment:
Maybe rather than directly routing to the post office, should we not send
via serversession? This would then sort the large message issue but also ensure
the message is treated like others, including going via broker plugins etc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 185161)
Time Spent: 1.5h (was: 1h 20m)
> Check message size sent over management API
> -------------------------------------------
>
> Key: ARTEMIS-2228
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2228
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.6.3
> Reporter: Howard Gao
> Assignee: Howard Gao
> Priority: Major
> Fix For: 2.6.4
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Currently user can send an arbitrary size of messages via management api
> (console for example) and this may break the buffer size limit and cause the
> broker throw unexpected exceptions. We need to put some check on the message
> size over the management API and reject the message if it's too big.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
