[
https://issues.apache.org/jira/browse/ARTEMIS-196?focusedWorklogId=185884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185884
]
ASF GitHub Bot logged work on ARTEMIS-196:
------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/19 17:14
Start Date: 16/Jan/19 17:14
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on issue #2490:
ARTEMIS-196 Implement Consumer Priority
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454854944
@clebertsuconic ok so i know whats going on, another feature i have
implemented for 2.7.0 reset of message groups, the test i had created is a
little over strict and tested exact current behaviour, rather than what is just
needed, that when resetting a message group, the selection on the next consumer
for that group would have been the next consumer that joined. Where as actually
when you reset the group in reality you just open the oppurtunity for another
consumer to take the group.
Because i have reworked this PR to make things more tidy and to abstract
bits, during dispatch we cycle through the consumers round robin, even if it
was a consumer group, as such on group reset it is the next current positioned
consumer. I dont think this is a bad behaviour change tbh (and the test in the
first place was created by me) either that or will end up with some of the
cleaner seperation of concerns unwound.
Im thinking i could add a repeat method to the iteration, so when a consumer
it will repeat, so return the same consumer, this would give same as before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 185884)
Time Spent: 2h 40m (was: 2.5h)
> Implementing Consumer Priority
> ------------------------------
>
> Key: ARTEMIS-196
> URL: https://issues.apache.org/jira/browse/ARTEMIS-196
> Project: ActiveMQ Artemis
> Issue Type: Sub-task
> Components: OpenWire
> Affects Versions: 1.0.0
> Reporter: Howard Gao
> Priority: Major
> Fix For: unscheduled
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> ref: http://activemq.apache.org/consumer-priority.html
> org.apache.activemq.QueueConsumerPriorityTest
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
