[
https://issues.apache.org/jira/browse/ARTEMIS-2170?focusedWorklogId=186634&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186634
]
ASF GitHub Bot logged work on ARTEMIS-2170:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jan/19 00:18
Start Date: 18/Jan/19 00:18
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #2427: ARTEMIS-2170
Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
URL: https://github.com/apache/activemq-artemis/pull/2427#discussion_r248889763
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java
##########
@@ -318,6 +313,30 @@ public synchronized boolean containsProperty(final
SimpleString key) {
}
}
+ public synchronized boolean removeProperty(Predicate<SimpleString>
propertyNamePredicate) {
Review comment:
Yep, then original version was using a slower method to remove a property
matching specific criteria and it was used in the hot path for every message.
This change has improved (for small binary message) the throughput of core
on my tests by a perceivable quantity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 186634)
Time Spent: 1h 10m (was: 1h)
> Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-2170
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2170
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> CoreMessage::checkProperties perform too many volatile read/write and has a
> too big body just to handle exceptional cases, while
> cleanupInternalProperties is called on the hot path of session send, but is
> performing too many synchronized operations and loopup on TypedProperties.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
