[
https://issues.apache.org/jira/browse/ARTEMIS-2176?focusedWorklogId=189329&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189329
]
ASF GitHub Bot logged work on ARTEMIS-2176:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/19 06:44
Start Date: 24/Jan/19 06:44
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2432:
[ARTEMIS-2176] RA connection properties are not propagated to XARecov…
URL: https://github.com/apache/activemq-artemis/pull/2432#discussion_r250482029
##########
File path:
artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java
##########
@@ -45,16 +45,41 @@
private final Map<String, String> properties;
private final ClientProtocolManagerFactory clientProtocolManager;
+ // ServerLocator properties
Review comment:
This is really bad duplication, it simply will be a nightmare to keep this
in sync as we add more and too brittle. A better solution has to exist, even if
it’s some work to abstract
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 189329)
Time Spent: 0.5h (was: 20m)
> RA connection properties are not propagated to XARecoveryConfig
> ---------------------------------------------------------------
>
> Key: ARTEMIS-2176
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2176
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.6.3
> Reporter: Bartosz Spyrko-Smietanko
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> XARecoveryConfig#createServerLocator uses only
> TransportConfiguration/DiscoveryGroupConfiguration to create a new instance
> of ServerLocator. That means that connection properties like connectionTTL or
> callFailoverTime are ignored. This can lead to network issues - eg.
> [https://issues.jboss.org/browse/WFLY-10725]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
