[ https://issues.apache.org/jira/browse/ARTEMIS-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750864#comment-16750864 ]
ASF subversion and git services commented on ARTEMIS-2170: ---------------------------------------------------------- Commit 6446d01a151a6e73b359c356b44fcf447961bd5a in activemq-artemis's branch refs/heads/master from Francesco Nigro [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=6446d01 ] ARTEMIS-2170 Optimized CoreMessage check and cleanup methods Any checkProperties();<usage of this.properties> pattern has been replaced by an atomic checkProperties().<usage of returned properties> to help both performance and consistency. The cleanup is now performed into CoreTypedProperties both for performance reasons (avoid lock/unlock many times) and consistency, given that the operation is now atomic. > Optimized CoreMessage's checkProperties and cleanupInternalProperties methods > ----------------------------------------------------------------------------- > > Key: ARTEMIS-2170 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2170 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker > Reporter: Francesco Nigro > Assignee: Francesco Nigro > Priority: Minor > Time Spent: 6h 50m > Remaining Estimate: 0h > > CoreMessage::checkProperties perform too many volatile read/write and has a > too big body just to handle exceptional cases, while > cleanupInternalProperties is called on the hot path of session send, but is > performing too many synchronized operations and loopup on TypedProperties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)