[
https://issues.apache.org/jira/browse/ARTEMIS-2238?focusedWorklogId=189722&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189722
]
ASF GitHub Bot logged work on ARTEMIS-2238:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/19 22:40
Start Date: 24/Jan/19 22:40
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2520:
ARTEMIS-2238 Enhancement to queueQuery on producer
URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250805377
##########
File path:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java
##########
@@ -533,6 +496,58 @@ private void doSendx(ActiveMQDestination destination,
}
}
+ private void checkDestination(ActiveMQDestination destination,
+ SimpleString address,
+ ClientSession clientSession) throws
JMSException {
+
+ // TODO: What to do with FQQN
+ if (!connection.containsKnownDestination(address)) {
+ try {
+ ClientSession.AddressQuery addressQuery =
clientSession.addressQuery(address);
+
+ boolean addressExists = addressQuery.isExists();
+ // first we check the address existence, and autoCreate it if
allowed in case it does not exists
+
+ if (!addressExists && addressQuery.isAutoCreateAddresses()) {
Review comment:
We should only create an address for a JMSQueue if we can create both the
Address and Queue, else you could end up creating an address, but not the queue
(old code had correct logic here)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 189722)
Time Spent: 3h (was: 2h 50m)
> JMS Producer queueQuery does not work when addressName != queueName
> -------------------------------------------------------------------
>
> Key: ARTEMIS-2238
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2238
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.6.4
> Environment: this is a regression created atÂ
> f3ace6afd726dc8e3c1c58c76e3fad3d5cfa357d
> Reporter: clebert suconic
> Priority: Major
> Fix For: 2.7.0, 2.6.5
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
