[
https://issues.apache.org/jira/browse/ARTEMIS-2238?focusedWorklogId=189740&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189740
]
ASF GitHub Bot logged work on ARTEMIS-2238:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/19 23:19
Start Date: 24/Jan/19 23:19
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2520:
ARTEMIS-2238 Enhancement to queueQuery on producer
URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250814957
##########
File path:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java
##########
@@ -533,6 +499,67 @@ private void doSendx(ActiveMQDestination destination,
}
}
+ private void checkDestination(ActiveMQDestination destination,
+ SimpleString address,
+ ClientSession clientSession) throws
JMSException {
+
+ // TODO: What to do with FQQN
+ if (!connection.containsKnownDestination(address)) {
+ try {
+ ClientSession.AddressQuery addressQuery =
clientSession.addressQuery(address);
+
+ boolean addressExists = addressQuery.isExists();
+ // first we check the address existence, and autoCreate it if
allowed in case it does not exists
+
+ if (!addressExists && addressQuery.isAutoCreateAddresses()) {
+
+ if (destination.isQueue() &&
!addressQuery.isAutoCreateQueues()) {
+ if (logger.isDebugEnabled()) {
+ logger.debug("Address " + address + " was not created
because we would not have permission to create queue");
+ }
+ // if it can't create the internal queue on JMS Queues, why
bother creating the address, just mark it false now
+ addressExists = false;
+ } else {
+ RoutingType addressType = destination.isQueue() ?
RoutingType.ANYCAST : RoutingType.MULTICAST;
+ clientSession.createAddress(address, addressType, true);
+ addressExists = true;
+ }
+ }
+
+
+ // Second we create the queue, but we only do it if the address
was created
+ if (destination.isQueue() && addressExists) {
+ ClientSession.QueueQuery queueQuery =
clientSession.queueQuery(address);
+ if (!queueQuery.isExists()) {
+ if (addressQuery.isAutoCreateQueues()) {
+ try {
+ if (destination.isTemporary()) {
+ session.createTemporaryQueue(destination,
RoutingType.ANYCAST, address, null, addressQuery);
+ } else {
+ session.createQueue(destination,
RoutingType.ANYCAST, address, null, true, true, addressQuery);
+ }
+ } catch (ActiveMQQueueExistsException thatsOK) {
+ // nothing to be done
+ }
+ } else {
+ throw new InvalidDestinationException("Queue " + address
+ " does not exist");
+ }
+ }
+ }
+
+ if (!addressExists) {
Review comment:
lets keep that exceptions are thrown from explicit points where checks are
done and fail, so can be more explicit and also we can debug where the check
fail occured by stack trace lines.
also as this is JMS interface, we should use words like Queue, Topic or
Destination in exception messages
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 189740)
Time Spent: 5h 20m (was: 5h 10m)
> JMS Producer queueQuery does not work when addressName != queueName
> -------------------------------------------------------------------
>
> Key: ARTEMIS-2238
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2238
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.6.4
> Environment: this is a regression created atÂ
> f3ace6afd726dc8e3c1c58c76e3fad3d5cfa357d
> Reporter: clebert suconic
> Priority: Major
> Fix For: 2.7.0, 2.6.5
>
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
