[jira] [Work logged] (ARTEMIS-2238) JMS Producer queueQuery does not work when addressName != queueName

[ASF GitHub Bot (JIRA)]

     [ 
https://issues.apache.org/jira/browse/ARTEMIS-2238?focusedWorklogId=190086&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-190086
 ]

ASF GitHub Bot logged work on ARTEMIS-2238:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Jan/19 16:24
            Start Date: 25/Jan/19 16:24
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on pull request #2520: 
ARTEMIS-2238 Enhancement to queueQuery on producer
URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251045430
 
 

 ##########
 File path: 
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java
 ##########
 @@ -397,6 +380,55 @@ public MessageProducer createProducer(final Destination 
destination) throws JMSE
       }
    }
 
+   void checkDestination(ActiveMQDestination destination) throws JMSException {
 
 Review comment:
   TBH I hate final methods...
   
   I have needed quite a few times to override them on test cases... so I only 
reserve the word final where there is a strong "business" case to not let it be 
overwritten.  but that's jut my opinion.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 190086)
    Time Spent: 10h  (was: 9h 50m)

> JMS Producer queueQuery does not work when addressName != queueName
> -------------------------------------------------------------------
>
>                 Key: ARTEMIS-2238
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2238
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.6.4
>         Environment: this is a regression created at 
> f3ace6afd726dc8e3c1c58c76e3fad3d5cfa357d
>            Reporter: clebert suconic
>            Priority: Major
>             Fix For: 2.7.0, 2.6.5
>
>          Time Spent: 10h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)