[jira] [Work logged] (ARTEMIS-2238) JMS Producer queueQuery does not work when addressName != queueName

[ASF GitHub Bot (JIRA)]

     [ 
https://issues.apache.org/jira/browse/ARTEMIS-2238?focusedWorklogId=190299&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-190299
 ]

ASF GitHub Bot logged work on ARTEMIS-2238:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Jan/19 02:28
            Start Date: 26/Jan/19 02:28
    Worklog Time Spent: 10m 
      Work Description: michaelandrepearce commented on pull request #2520: 
ARTEMIS-2238 Enhancement to queueQuery on producer
URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182656
 
 

 ##########
 File path: 
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java
 ##########
 @@ -393,57 +395,18 @@ private void doSendx(ActiveMQDestination destination,
          if (defaultDestination == null) {
             throw new UnsupportedOperationException("Destination must be 
specified on send with an anonymous producer");
          }
-
          destination = defaultDestination;
-      } else {
-         if (defaultDestination != null) {
-            if (!destination.equals(defaultDestination)) {
-               throw new UnsupportedOperationException("Where a default 
destination is specified " + "for the sender and a destination is " + 
"specified in the arguments to the send, " + "these destinations must be 
equal");
-            }
+      } else if (defaultDestination != null) {
+         if (!destination.equals(defaultDestination)) {
+            throw new UnsupportedOperationException("Where a default 
destination is specified " + "for the sender and a destination is " + 
"specified in the arguments to the send, " + "these destinations must be 
equal");
          }
+      } else {
+         session.checkDestination(destination);
 
          address = destination.getSimpleAddress();
 
 Review comment:
   back on a proper pc,
   
   i was meaning only:
            address = destination.getSimpleAddress();
    
   if defaultdestination != null, then don't need to do 
session.checkDestination(destination), as we checked the destination already 
when we created the message producer
   
   
   doesn't matter too much as connection.containsKnownDestination(address) 
should return true anyhow, meaning it avoids the expensive bit. 
   
   **Im still happy with PR to merge, just a comment**
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 190299)
    Time Spent: 13h  (was: 12h 50m)

> JMS Producer queueQuery does not work when addressName != queueName
> -------------------------------------------------------------------
>
>                 Key: ARTEMIS-2238
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2238
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.6.4
>         Environment: this is a regression created at 
> f3ace6afd726dc8e3c1c58c76e3fad3d5cfa357d
>            Reporter: clebert suconic
>            Priority: Major
>             Fix For: 2.7.0, 2.6.5
>
>          Time Spent: 13h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)