[ 
https://issues.apache.org/jira/browse/AMQ-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757391#comment-16757391
 ] 

Christopher L. Shannon commented on AMQ-7144:
---------------------------------------------

I figured that the exception you saw might have been a 
RejectionExecutionException but the point I'm making about preventing the error 
in the first place is it may not simply good enough to just swallow the 
exception and continue as the error could be fatal.  In this case the thread 
pool size is set to int max so I wouldn't expect a RejectionExecutionException 
unless the thread pool was shut down.

In fact the inactivity monitor logic already checks for 
RejectionExecutionException (and for the pool being shut down) and purposely 
propagates the error up because it's not normal to be rejected and probably 
means out of memory or something bad happened to the broker (fatal error)

So I just want to make sure we are not going to be ignoring an out of memory 
error or something by swallowing an exception that should be considered fatal 
and continuing when we should really be propagating the error up.

> Issue with Timer in AbstactInactivityMonitor
> --------------------------------------------
>
>                 Key: AMQ-7144
>                 URL: https://issues.apache.org/jira/browse/AMQ-7144
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.x
>            Reporter: Megaraj Mahadikar
>            Priority: Critical
>
> Hi,
> If there is an exception in the Timers that schedules the write checker or 
> read check, then this timer is cancelled (refer the java docs of 
> java.util.Timer). As a result of this any new connection to the broker will 
> never go through since the same Timer is used again to schedule the write or 
> read checker. This issue affects the complete broker and the broker needs to 
> be restarted to recover from this issue.
> Ideally any such exceptions within the Timer must be never thrown back which 
> causes the Timer to be cancelled. 
> Regards,
> Megaraj



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to