[
https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=193121&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-193121
]
ASF GitHub Bot logged work on ARTEMIS-2226:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/19 00:54
Start Date: 01/Feb/19 00:54
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2528:
ARTEMIS-2226 last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252900294
##########
File path:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java
##########
@@ -30,10 +30,12 @@
public class MQTTSession {
- static Map<String, MQTTSessionState> SESSIONS = new ConcurrentHashMap<>();
+ private static Map<String, MQTTSessionState> SESSIONS = new
ConcurrentHashMap<>();
Review comment:
Looking at this im bit worried that this is a static in first place, e.g.
its possible to have multiple embedded brokers, in that case each broker
shouldnt share any state, by being static means they would.
really should be held as a non static at level above such as
MQTTConnectionManager.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 193121)
Time Spent: 5h 40m (was: 5.5h)
> (MQTT)In the cluster,the last consumer connection should close the previous
> consumer connection
> -----------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-2226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2226
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Shiping Liang
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> Multiple consumers using the same clientId in the cluster, the last consumer
> connection should close the previous consumer connection!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
