[
https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=194106&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-194106
]
ASF GitHub Bot logged work on ARTEMIS-2226:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/19 16:38
Start Date: 04/Feb/19 16:38
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2528:
ARTEMIS-2226 last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253543767
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
##########
@@ -47,7 +47,8 @@
SESSION_CREATED(26),
SESSION_CLOSED(27),
MESSAGE_DELIVERED(28),
- MESSAGE_EXPIRED(29);
+ MESSAGE_EXPIRED(29),
+ CONNECTION_CONNECTED(30);
Review comment:
re
> The clientId is read from the client's connection message. The logic for
reading the clientId cannot be placed in the CORE code， when create a
connection or create a session.
during handling connect packet in MQTTConnectionManager, the clientid is set
on the connection BEFORE createServerSession as such it will be available when
the SESSION_CREATED notification is created,
MQTTConnectionManager lines 78, 79
```
session.getConnection().setClientID(clientId);
ServerSessionImpl serverSession = createServerSession(username, password);
```
just need to populate the extra field which would be available at the time
via
```
session.getRemotingConnection().getClientID() .
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 194106)
Time Spent: 17h (was: 16h 50m)
> (MQTT)In the cluster,the last consumer connection should close the previous
> consumer connection
> -----------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-2226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2226
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Shiping Liang
> Priority: Major
> Time Spent: 17h
> Remaining Estimate: 0h
>
> Multiple consumers using the same clientId in the cluster, the last consumer
> connection should close the previous consumer connection!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
