[
https://issues.apache.org/jira/browse/ARTEMIS-2245?focusedWorklogId=194188&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-194188
]
ASF GitHub Bot logged work on ARTEMIS-2245:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/19 19:03
Start Date: 04/Feb/19 19:03
Worklog Time Spent: 10m
Work Description: orpiske commented on issue #2536: ARTEMIS-2245
Implement Docker images
URL: https://github.com/apache/activemq-artemis/pull/2536#issuecomment-460370503
This looks very cool @franz1981!
A few suggestions:
1. I'd probably arrange the ARTEMIS_VERSION so that it can be both a
variable and an argument to the dockerfile. That way, you are not forced to
change the Dockerfile for every release.
```
ARG ARTEMIS_VERSION
ENV ARTEMIS_VERSION ${ARTEMIS_VERSION:-2.7.0-SNAPSHOT}
LABEL ARTEMIS_VERSION=${ARTEMIS_VERSION}
```
2. I think it would be good to label the Centos and Ubuntu images
accordingly.
```LABEL ARTEMIS_BASE_SYSTEM=ubuntu```
Another thing you could do is consolidate the 2 files in one, so you could
possibly reuse the container build code post the part that you setup the
initial system. But I consider that a matter of personal taste and nothing that
could give immediate gains to the image IMHO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 194188)
Time Spent: 40m (was: 0.5h)
> Implement Docker images
> -----------------------
>
> Key: ARTEMIS-2245
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2245
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Affects Versions: 2.6.4
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
