[
https://issues.apache.org/jira/browse/ARTEMIS-2246?focusedWorklogId=195727&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-195727
]
ASF GitHub Bot logged work on ARTEMIS-2246:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/19 15:39
Start Date: 07/Feb/19 15:39
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #2541:
ARTEMIS-2246 clarify max-disk-usage 'default'
URL: https://github.com/apache/activemq-artemis/pull/2541#discussion_r254735557
##########
File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
##########
@@ -749,10 +749,10 @@
</xsd:annotation>
</xsd:element>
- <xsd:element name="max-disk-usage" type="xsd:int" default="90"
maxOccurs="1" minOccurs="0">
+ <xsd:element name="max-disk-usage" type="xsd:int" default="100"
maxOccurs="1" minOccurs="0">
Review comment:
I will merge it..but I will add a PR to have a system property to change the
value to -1, and have the maven settings setting it to 100.
Some of my CI boxes are close to 90... so this would break things as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 195727)
Time Spent: 2.5h (was: 2h 20m)
> Documentation for configuration max-disk-usage is inaccurate.
> -------------------------------------------------------------
>
> Key: ARTEMIS-2246
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2246
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.6.4
> Reporter: Leo Provido
> Assignee: Justin Bertram
> Priority: Major
> Fix For: 2.7.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> During the execution of tests involving sending messages to the System, we
> observed that the System started blocking messages before the disk is full.
> According to the Configuration Reference
> ([https://activemq.apache.org/artemis/docs/1.4.0/configuration-index.html])
> documentation, the default value of the configuration max-disk-usage is 100.
> However, we discovered that the actual default value of max-disk-usage is 90.
> The file inspected is ./etc/broker.xml. Thus, the documentation is deemed
> inaccurate.
> We have the opinion that severity of this incident is Major because a) the
> documentation provides an inaccurate piece of information that influences the
> way we design our mitigation strategies for risks surrounding hardware
> resources utilization, and b) we don’t necessarily have the bandwidth to
> review all default configuration values.
> Inaccurate information may cause failure to provide message brokering
> services despite mitigation strategies being in place.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
