[
https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=197622&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197622
]
ASF GitHub Bot logged work on ARTEMIS-2226:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Feb/19 14:43
Start Date: 12/Feb/19 14:43
Worklog Time Spent: 10m
Work Description: onlyMIT commented on pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255983228
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
##########
@@ -351,10 +355,15 @@ private String appendIgnoresToFilter(String
filterString) {
}
filterString += "!" + storeAndForwardPrefix;
filterString += ",!" + managementAddress;
- filterString += ",!" + managementNotificationAddress;
return filterString;
}
+ private String createPermissiveManagementNotificationToFilter() {
+ StringBuilder filterBuilder = new
StringBuilder(ManagementHelper.HDR_NOTIFICATION_TYPE).append(" = '")
Review comment:
The inter-cluster notification message needs to specify the routing address
to route the message. Different from the notifications of CONSUMER_CREATE and
BINDING_ADD, the routing address (the address created or consumed by itself)
has been determined before the notification is sent. When sending a
SESSION_CREATED notification, We can't know which address to use, so I chose to
use the `ManagementManagementAddress`, which is consumed by each node in the
cluster-connection.
But the notification message using the `ManagementNotificationAddress`
address is filtered by the filter, so I modified the filter and allow
SESSION_CREATED notification to be routed to other nodes in the cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 197622)
Time Spent: 21h (was: 20h 50m)
> (MQTT)In the cluster,the last consumer connection should close the previous
> consumer connection
> -----------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-2226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2226
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Shiping Liang
> Priority: Major
> Time Spent: 21h
> Remaining Estimate: 0h
>
> Multiple consumers using the same clientId in the cluster, the last consumer
> connection should close the previous consumer connection!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
