[
https://issues.apache.org/jira/browse/ARTEMIS-2118?focusedWorklogId=199054&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-199054
]
ASF GitHub Bot logged work on ARTEMIS-2118:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Feb/19 01:21
Start Date: 15/Feb/19 01:21
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on issue #2548:
ARTEMIS-2118 Enhanced Message Groups Support
URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463867719
@franz1981 the needing to copy a IntObjectHashmap, still didnt fit right
with me.
As such have had a sit and think.
Have done a small refactor that means we can still use IntObjectHashmap
without needing to clone it over.
Essentially in queueimpl for message groups, we only use,
put
get
remove
clear
size
iterate over the collection so we can for remove consumers.
As such rather than using map interface i made a new Interface named
'MessageGroups' with just this subset, as such makes implementations that are
not backed by a plain forward map a little easier as less methods to contend
with and also we can add or tweek an methods signature if needed, e.g. i can
still use IntObjectHashMap but i don't have to make it fully implement
Map<SimpleString, Consumer>.
Lastly should others be wanted in the future as less methods to implement if
the backing store isnt a map will be easier to implement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 199054)
Time Spent: 8h 10m (was: 8h)
> Enhanced Message Groups Support
> --------------------------------
>
> Key: ARTEMIS-2118
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2118
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Reporter: Michael Andre Pearce
> Assignee: Michael Andre Pearce
> Priority: Major
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> This ticket is for supporting some Message Group Enhancements.
>
> Currently Artemis implements message groups in a simple way, equivalent to
> SimpleMessageGroupMap in activemq5.
> [http://activemq.apache.org/message-groups.html]
> "SimpleMessageGroupMap keeps track of every group but suffers from unbounded
> memory use."
>
> For use cases migrating from activemq5 its important artemis supports similar
> MessageGroupHashBucked feature.
> "MessageGroupHashBucked keeps track of every group and has bounded memory
> use."
> As such, this JIRA is to add support for being able to enable a semantic
> equivalent to MessageGroupHashBucket from activemq5, at the queue level.
>
> Also currently it is not possible for a specific queue disable grouping, this
> can be useful where a shared address by many queues, where some consumers
> care for ordering and others do not.
> Lastly add an ability to rebalance message groups when a consumer is added,
> this is useful where you want groups more evenly balanced when consumers come
> online, even after dispatching started.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
