[
https://issues.apache.org/jira/browse/ARTEMIS-2183?focusedWorklogId=203253&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-203253
]
ASF GitHub Bot logged work on ARTEMIS-2183:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/19 15:37
Start Date: 24/Feb/19 15:37
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on issue #2564:
ARTEMIS-2183 Useless statement in public synchronized List
URL: https://github.com/apache/activemq-artemis/pull/2564#issuecomment-466787498
Id agree with franz for it not to be causing issue you got to think is this
even being used. Is it and the calling code become redundant. And if not there
must be a test case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 203253)
Time Spent: 1h 10m (was: 1h)
> Useless statement in public synchronized List<MessageReference>
> RefsOperation#getRelatedMessageReferences()
> -----------------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-2183
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2183
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Reporter: Jiri Daněk
> Priority: Trivial
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {code}
> @Override
> public synchronized List<MessageReference> getRelatedMessageReferences() {
> List<MessageReference> listRet = new LinkedList<>();
> listRet.addAll(listRet); // 🐟
> return listRet;
> }
> {code}
> https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java#L184
> The method returns empty list, which may be wrong (looking at the method
> name). There is absolutely nothing gained by adding content of empty inst
> into itself, as in {{listRet.addAll(listRet)}}.
> Doing the addAll thing can be an error under ErrorProne compiler.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
