[
https://issues.apache.org/jira/browse/AMQ-7159?focusedWorklogId=208741&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-208741
]
ASF GitHub Bot logged work on AMQ-7159:
---------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/19 11:29
Start Date: 06/Mar/19 11:29
Worklog Time Spent: 10m
Work Description: cshannon commented on pull request #349: AMQ-7159 -
Adding a new attribute on PersistenceAdapterViewMBean to s…
URL: https://github.com/apache/activemq/pull/349#discussion_r262901153
##########
File path:
activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/MessageDatabase.java
##########
@@ -249,6 +250,7 @@ public void writePayload(Metadata object, DataOutput
dataOut) throws IOException
protected PageFile pageFile;
protected Journal journal;
protected Metadata metadata = new Metadata();
+ protected PersistenceAdapterStatistics persistenceAdapterStatistics = new
PersistenceAdapterStatistics();
Review comment:
I would probably make this final and then I would also add a getter for this
object and also expose it under KahaDBPersistenceAdapter. I routinely use
embedded brokers for example and being able to access this through
KahaDBPersistenceAdapter without JMX would be nice. Inside
KahaDBPersistenceAdapter I would just return the actual
PersistenceAdapterStatistics object so someone could access it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 208741)
Time Spent: 40m (was: 0.5h)
> Adding a new attribute on PersistenceAdapterViewMBean to show information
> about Storage write/read latency
> ----------------------------------------------------------------------------------------------------------
>
> Key: AMQ-7159
> URL: https://issues.apache.org/jira/browse/AMQ-7159
> Project: ActiveMQ
> Issue Type: Improvement
> Components: KahaDB
> Reporter: Alan Protasio
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Hi all,
> I was trying to find a way to monitor the real storage write latency observed
> by ActiveMq and I could not find.
> The only thing that I found was a log line:
> [https://github.com/apache/activemq/blob/master/activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/MessageDatabase.java#L1142]
>
> I think would be really useful to have this information on the
> PersistenceAdapterViewMBean.
>
> The change proposed create a new attribute on this bean called "Statistics" -
> that contains write and read times statistics - and a operation to reset it.
>
> OBS: This information can be extended to all other persistence adapters.
>
> Thanks
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
