[
https://issues.apache.org/jira/browse/ARTEMIS-2292?focusedWorklogId=221750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221750
]
ASF GitHub Bot logged work on ARTEMIS-2292:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/19 14:11
Start Date: 02/Apr/19 14:11
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #2602:
ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue
URL: https://github.com/apache/activemq-artemis/pull/2602#discussion_r271325506
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -1582,7 +1582,7 @@ public void run() {
public void run() {
for (Queue queue : getLocalQueues()) {
if (!queue.isInternalQueue() &&
QueueManagerImpl.isAutoDelete(queue) &&
QueueManagerImpl.consumerCountCheck(queue) &&
QueueManagerImpl.delayCheck(queue) &&
QueueManagerImpl.messageCountCheck(queue)) {
- QueueManagerImpl.deleteAutoCreatedQueue(server, queue);
+ QueueManagerImpl.deleteAutoDeleteQueue(server, queue);
Review comment:
Do you mind if I rename this to performAutoDeleteQueue?
I can amend it myself if you agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 221750)
Time Spent: 40m (was: 0.5h)
> Auto-delete set at queue level is not honored when not auto-created
> -------------------------------------------------------------------
>
> Key: ARTEMIS-2292
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2292
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.7.0
> Reporter: Michael Andre Pearce
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> ARTEMIS-2263 added the ability to set auto-delete at the queue level, this
> though is ignored if the queue is created not by auto-create. As such
> subscription queues where the user may want to set auto-delete, are not being
> auto-deleted as these are not treated as an auto-created queue
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
