[
https://issues.apache.org/jira/browse/AMQ-7177?focusedWorklogId=224742&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-224742
]
ASF GitHub Bot logged work on AMQ-7177:
---------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/19 01:41
Start Date: 09/Apr/19 01:41
Worklog Time Spent: 10m
Work Description: zhfeng commented on pull request #353: AMQ-7177 -
Fixing to change the method name to createSessionInternal
URL: https://github.com/apache/activemq/pull/353
https://issues.apache.org/jira/browse/AMQ-7177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 224742)
Time Spent: 10m
Remaining Estimate: 0h
> ActiveMQXAConnection should not override the createSession method
> -----------------------------------------------------------------
>
> Key: AMQ-7177
> URL: https://issues.apache.org/jira/browse/AMQ-7177
> Project: ActiveMQ
> Issue Type: Bug
> Components: JMS client
> Reporter: Zheng Feng
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It should not override the method of the super class. And in the term of the
> [JMS spec|https://docs.oracle.com/javaee/7/api/javax/jms/XAConnection.html],
> it needs to return the Session but not the XASession.
> {code:java}
> public Session createSession(boolean transacted, int acknowledgeMode) throws
> JMSException {
> checkClosedOrFailed();
> ensureConnectionInfoSent();
> return new ActiveMQXASession(this, getNextSessionId(), getAckMode(),
> isDispatchAsync());
> }
> {code}
> The simple fix could change the method name createSession() to
> createSessionInternal().
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
