[ 
https://issues.apache.org/jira/browse/ARTEMIS-2311?focusedWorklogId=229407&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229407
 ]

ASF GitHub Bot logged work on ARTEMIS-2311:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Apr/19 21:32
            Start Date: 17/Apr/19 21:32
    Worklog Time Spent: 10m 
      Work Description: michaelandrepearce commented on pull request #2627: 
ARTEMIS-2311 Dealing with Protocol conversions and JMSReplyTo
URL: https://github.com/apache/activemq-artemis/pull/2627#discussion_r276442419
 
 

 ##########
 File path: 
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/CoreAmqpConverter.java
 ##########
 @@ -355,6 +359,15 @@ public static AMQPMessage fromCore(ICoreMessage 
coreMessage) throws Exception {
       }
    }
 
+   private static String removePrefix(String address) {
 
 Review comment:
   ServerSessionImpl.removePrefix invokes it, you could probably invoke it via 
the same server session, that way it would pick up the same config as server 
session already has done for you.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 229407)
    Time Spent: 11h 10m  (was: 11h)

> JMSReplyTo insconsistent when dealing with Protocol conversions
> ---------------------------------------------------------------
>
>                 Key: ARTEMIS-2311
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2311
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: AMQP, Broker, OpenWire
>    Affects Versions: 2.7.0
>            Reporter: clebert suconic
>            Assignee: clebert suconic
>            Priority: Major
>             Fix For: 2.8.0
>
>          Time Spent: 11h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to