[
https://issues.apache.org/jira/browse/ARTEMIS-2311?focusedWorklogId=229460&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229460
]
ASF GitHub Bot logged work on ARTEMIS-2311:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/19 22:34
Start Date: 17/Apr/19 22:34
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2627:
ARTEMIS-2311 Dealing with Protocol conversions and JMSReplyTo
URL: https://github.com/apache/activemq-artemis/pull/2627#discussion_r276455341
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/AmqpCoreConverter.java
##########
@@ -324,7 +324,29 @@ private static ServerJMSMessage
processProperties(ServerJMSMessage jms, Properti
jms.setJMSType(properties.getSubject());
}
if (properties.getReplyTo() != null) {
- jms.setJMSReplyTo(new ServerDestination(properties.getReplyTo()));
+ Byte value = (Byte)(annotations != null ?
annotations.getValue().get(AMQPMessageSupport.JMS_REPLY_TO_TYPE_MSG_ANNOTATION)
: AMQPMessageSupport.QUEUE_TYPE);
Review comment:
Can get number type casting issues, safer to cast to Number, and then call
(after null check) .byteValue()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 229460)
Time Spent: 13h 10m (was: 13h)
> JMSReplyTo insconsistent when dealing with Protocol conversions
> ---------------------------------------------------------------
>
> Key: ARTEMIS-2311
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2311
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP, Broker, OpenWire
> Affects Versions: 2.7.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Priority: Major
> Fix For: 2.8.0
>
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
