[
https://issues.apache.org/jira/browse/ARTEMIS-2320?focusedWorklogId=234009&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234009
]
ASF GitHub Bot logged work on ARTEMIS-2320:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/19 16:39
Start Date: 27/Apr/19 16:39
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on issue #2651: ARTEMIS-2320
Fix ClassCanBeStatic errorprone warning
URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487300738
@michaelandrepearce I don't think that's a good idea. static classes can be
useful to avoid clutter, when the logic only makes sense in the context of that
class.
static classes can be in their own class file.. should is a strong word on
this IMHO.
Like the other day I moved an independent class as a static class file, as
the class only made sense in the context of the test.
Having said that though, I don'w think we should abuse static classes... I'm
just saying that in some cases the class doesn't make sense as an independent
class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 234009)
Time Spent: 2h 50m (was: 2h 40m)
> Upgrade errorprone compiler dependency to 2.3.3 and review the new warnings
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-2320
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2320
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.7.0
> Reporter: Jiri Daněk
> Priority: Minor
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
