[
https://issues.apache.org/jira/browse/ARTEMIS-2328?focusedWorklogId=235653&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-235653
]
ASF GitHub Bot logged work on ARTEMIS-2328:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/19 05:06
Start Date: 01/May/19 05:06
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2656:
ARTEMIS-2328 Routing after empty addresses could lead to invalid mess…
URL: https://github.com/apache/activemq-artemis/pull/2656#discussion_r280006284
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -907,8 +907,7 @@ public RoutingStatus route(final Message message,
AddressInfo addressInfo = addressManager.getAddressInfo(address);
if (bindingMove != null) {
- context.clear();
- context.setReusable(false);
+ context.clear().setReusable(false);
Review comment:
really is that needed? having on two lines helps when running debuggers e.g.
via ide's and stepping through
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 235653)
Time Spent: 0.5h (was: 20m)
> Invalid Routing with Empty Topics and mixed Session
> ---------------------------------------------------
>
> Key: ARTEMIS-2328
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2328
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.8.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Priority: Major
> Fix For: 2.9.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> if you call sender.send() into a valid queue
> and then sender.send(); into an empty address (topic without subscriptions)
>
> Then cached routing would use the previous version on a valid queue and
> duplicate messages.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
