[
https://issues.apache.org/jira/browse/ARTEMIS-2327?focusedWorklogId=236291&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-236291
]
ASF GitHub Bot logged work on ARTEMIS-2327:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/May/19 14:01
Start Date: 02/May/19 14:01
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2655:
ARTEMIS-2327 ExceptionListener invoked when connection level exception
URL: https://github.com/apache/activemq-artemis/pull/2655#discussion_r280432506
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java
##########
@@ -451,7 +451,9 @@ public Packet sendBlocking(final Packet packet,
}
if (response == null) {
- throw
ActiveMQClientMessageBundle.BUNDLE.timedOutSendingPacket(connection.getBlockingCallTimeout(),
packet.getType());
+ ActiveMQException e =
ActiveMQClientMessageBundle.BUNDLE.timedOutSendingPacket(connection.getBlockingCallTimeout(),
packet.getType());
+ connection.fail(e);
Review comment:
@clebertsuconic have just pushed a small change to that test, originally it
would just repeat the same over and over, where as test is just expecting it
ever to be called once, so made the interceptor in the test to adjust the
behaviour just the once using a bool
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 236291)
Time Spent: 8h (was: 7h 50m)
> JMS Connection ExceptionListener not invoked when
> ActiveMQConnectionTimedOutException occurs on sendPacket
> ----------------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-2327
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2327
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.7.0
> Reporter: Michael Andre Pearce
> Priority: Major
> Time Spent: 8h
> Remaining Estimate: 0h
>
> When a connection level exception occurs it seems in one case, whilst the
> exception is returned to calling code, exception listeners set at the
> connection are not being invoked.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
