[
https://issues.apache.org/jira/browse/ARTEMIS-2321?focusedWorklogId=241091&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-241091
]
ASF GitHub Bot logged work on ARTEMIS-2321:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/19 14:30
Start Date: 13/May/19 14:30
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #2667: ARTEMIS-2321
Non-blocking Page::read on page cache
URL: https://github.com/apache/activemq-artemis/pull/2667#discussion_r283374620
##########
File path:
artemis-server/src/test/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImplTest.java
##########
@@ -0,0 +1,77 @@
+/*
+ * Copyright The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.paging.cursor.impl;
+
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.activemq.artemis.core.paging.PagingStore;
+import org.apache.activemq.artemis.core.paging.cursor.PageCache;
+import org.apache.activemq.artemis.core.paging.impl.Page;
+import org.apache.activemq.artemis.core.persistence.StorageManager;
+import org.apache.activemq.artemis.utils.actors.ArtemisExecutor;
+import org.junit.Assert;
+import org.junit.Test;
+
+import static java.util.Collections.emptyList;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyInt;
+import static org.mockito.ArgumentMatchers.anyLong;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class PageCursorProviderImplTest {
+
+ @Test(timeout = 30_000)
+ public void shouldAllowsConcurrentPageReads() throws Exception {
Review comment:
uh right..and I see that there are conflicts...
let me me fix them...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 241091)
Time Spent: 12h 10m (was: 12h)
> Paging scalability and GC improvements
> --------------------------------------
>
> Key: ARTEMIS-2321
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2321
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.8.0
> Reporter: Francesco Nigro
> Priority: Major
> Fix For: 2.9.0
>
> Time Spent: 12h 10m
> Remaining Estimate: 0h
>
> PageCursorProviderImpl::getPageCache's on cache miss is blocking the whole
> softCache until the requested page isn't fully read, making other threads
> unable to make progress by querying the cache.
> It would be better to make the page read operation a non-blocking operation
> for the whole cache, allowing threads that need different pageId to make
> progress.
> Other improvements:
> * PageCursorProviderImpl can use specialized primitive hash maps to reduce
> memory footprint (that would cause some page entries to be collected
> prematurely)
> * PageCache children can avoid to maintain a reference to a Page
> * PagingStoreImpl perform many unnecessary volatile stores/loads and some
> fields can be turned into plain ones, avoiding expensive atomic operations
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
