[
https://issues.apache.org/jira/browse/ARTEMIS-2336?focusedWorklogId=242950&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242950
]
ASF GitHub Bot logged work on ARTEMIS-2336:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/May/19 23:10
Start Date: 15/May/19 23:10
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2666:
ARTEMIS-2336 Use zero copy to replicate journal/page/large message file
URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r284485851
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationSyncFileMessage.java
##########
@@ -197,6 +232,15 @@ public void decodeRest(final ActiveMQBuffer buffer) {
}
}
+ private void readFile(ByteBuffer buffer) {
+ try (FileInputStream fis = new FileInputStream(file); FileChannel
channel = fis.getChannel()) {
+ channel.position(offset);
+ channel.read(buffer);
Review comment:
InVM is very important for performance. There is a use case at a company i
know heavily reliant on InVM perf. It doesnt need to speed up, but it cant
regress. Please ensure theres no perf regression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 242950)
Time Spent: 4h (was: 3h 50m)
> Use zero copy to replicate journal/page/large message file
> ----------------------------------------------------------
>
> Key: ARTEMIS-2336
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2336
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: yangwei
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Use sendfile to replicate files during backup sever bootstrap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
