[ 
https://issues.apache.org/jira/browse/ARTEMIS-2342?focusedWorklogId=243633&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-243633
 ]

ASF GitHub Bot logged work on ARTEMIS-2342:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/May/19 21:08
            Start Date: 16/May/19 21:08
    Worklog Time Spent: 10m 
      Work Description: jamezp commented on pull request #2672: ARTEMIS-2342 
Use a URL instead of a URI for the logging.configuration…
URL: https://github.com/apache/activemq-artemis/pull/2672
 
 
   … property. The property the log manager itself expects is a URL which could 
result in an invalid URI missing the // prefix after file:.
   
   https://issues.apache.org/jira/browse/ARTEMIS-2342
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 243633)
            Time Spent: 10m
    Remaining Estimate: 0h

> The reload logging configuration at runtime for Active MQ Servers may log 
> warnings
> ----------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2342
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2342
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: AMQP
>    Affects Versions: 2.6.4, 2.7.0, 2.8.0, 2.8.1
>            Reporter: James R. Perkins
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The issue [JBEAP-16896|[https://issues.jboss.org/browse/JBEAP-16896]] has 
> some details about the issue. The stack trace logged as a warning is:
> {noformat} 
> 2019-05-13 11:45:11,419 WARN  [org.apache.activemq.artemis.core.server] 
> (ServerService Thread Pool -- 78) AMQ222277: Problem initializing automatic 
> logging configuration reload for 
> file:C:\Java\jboss\jboss-as\standalone\configuration/logging.properties: 
> java.net.URISyntaxException: Illegal character in opaque part at index 7: 
> file:C:\Java\jboss\jboss-as\standalone\configuration/logging.properties
>       at java.net.URI$Parser.fail(URI.java:2848)
>       at java.net.URI$Parser.checkChars(URI.java:3021)
>       at java.net.URI$Parser.parse(URI.java:3058)
>       at java.net.URI.<init>(URI.java:588)
>       at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:2369)
>       at 
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:64)
>       at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:544)
>       at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:481)
>       at 
> org.apache.activemq.artemis.jms.server.impl.JMSServerManagerImpl.start(JMSServerManagerImpl.java:376)
>       at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.doStart(JMSService.java:206)
>       at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.access$000(JMSService.java:65)
>       at 
> org.wildfly.extension.messaging.activemq.jms.JMSService$1.run(JMSService.java:100)
>       at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>       at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>       at 
> org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
>       at 
> org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1985)
>       at 
> org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1487)
>       at 
> org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1349)
>       at java.lang.Thread.run(Thread.java:748)
>       at org.jboss.threads.JBossThread.run(JBossThread.java:485)
> {noformat}
>  
> This also means the server will not reload the logging configuration as it 
> fails. The reason being in this case is because the {{logging.configuration}} 
> is stored as a URL not a URI and the line in 
> [ActiveMQServerImpl|https://github.com/apache/activemq-artemis/blob/2.8.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java#L2775]
>  uses {{new URI(System.getProperty("logging.configuration")).toURL()}} and it 
> should just be using {{new URL(System.getProperty("logging.configuration"))}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to