[
https://issues.apache.org/jira/browse/ARTEMIS-2368?focusedWorklogId=253577&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-253577
]
ASF GitHub Bot logged work on ARTEMIS-2368:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/19 07:08
Start Date: 04/Jun/19 07:08
Worklog Time Spent: 10m
Work Description: wy96f commented on pull request #2693: ARTEMIS-2368 Fix
races on closing consumer
URL: https://github.com/apache/activemq-artemis/pull/2693
There are some race conditions between closing consumer and session failover:
1. When sending SessionConsumerCloseMessage timeout, conn::fail() is called
resulting in current consumer is recreated on server side again but removed on
client side.
2. Between SessionConsumerCloseMessage sending and
session::removeConsume(), session failover happens resulting in consumer
inconsistency.
3. When an iteration over the consumers entrySet is made to recreate
consumer during session failover process, consumer::close() is called, maybe
leading to consumer inconsistency or ConcurrentModificationException thrown.
We traverse through the cloned consumers entrySet, add synchronized block
and check if consumer is closed while recreating consumer to fix the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 253577)
Time Spent: 10m
Remaining Estimate: 0h
> Fix races on closing consumer
> -----------------------------
>
> Key: ARTEMIS-2368
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2368
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.9.0
> Reporter: yangwei
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are some race conditions between closing consumer and session failover:
> # When sending SessionConsumerCloseMessage timeout, conn::fail() is called
> resulting in current consumer is recreated on server side again but removed
> on client side.
> # Between SessionConsumerCloseMessage sending and session::removeConsume(),
> session failover happens resulting in consumer inconsistency.
> # When an iteration over the consumers entrySet is made to recreate consumer
> during session failover process, consumer::close() is called, maybe leading
> to consumer inconsistency or ConcurrentModificationException thrown.
> We traverse through the cloned consumers entrySet, add synchronized block and
> check if consumer is closed while recreating consumer to fix the issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
