[
https://issues.apache.org/jira/browse/ARTEMIS-2371?focusedWorklogId=254370&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254370
]
ASF GitHub Bot logged work on ARTEMIS-2371:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/19 13:22
Start Date: 05/Jun/19 13:22
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #2694: ARTEMIS-2371
Message with huge header shuts broker down
URL: https://github.com/apache/activemq-artemis/pull/2694#issuecomment-499080624
I'm not totally sure about it, but we could put a check even before in the
process chain ie
```java
private static Message asLargeMessage(Message message, StorageManager
storageManager) throws Exception {
ICoreMessage coreMessage = message.toCore();
//in order to avoid headers
if (message.isDurable()) {
final int estimatedHeaderSize =
coreMessage.getHeadersAndPropertiesEncodeSize();
if (estimatedHeaderSize > storageManager.getMaxRecordSize()) {
throw new ActiveMQLargeMessageException("The large message has a
too big header size");
}
}
LargeServerMessage lsm =
storageManager.createLargeMessage(storageManager.generateID(), coreMessage);
ActiveMQBuffer buffer = coreMessage.getReadOnlyBodyBuffer();
final int readableBytes = buffer.readableBytes();
lsm.addBytes(buffer);
lsm.releaseResources();
lsm.putLongProperty(Message.HDR_LARGE_BODY_SIZE, readableBytes);
return lsm;
}
```
Not sure if `isDurable` and `getHeadersAndPropertiesEncodeSize` are the
correct methods , but the idea is to avoid that regardless the protocol used a
large message won't be created/replicated at all if the journal is not able to
persist it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 254370)
Time Spent: 20m (was: 10m)
> AMQP: message with very large header shuts broker down
> ------------------------------------------------------
>
> Key: ARTEMIS-2371
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2371
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP, Broker
> Affects Versions: 2.9.0
> Reporter: Domenico Bruscino
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When there is one really large header sent with the message, the broker does
> not have room for it and shuts down. Using an AMQP client send a message with
> an extremely large header (>600000 bytes) and broker default configuration
> this will trigger the following exception:
> {code:java}
> [Thread-0
> (ActiveMQ-IO-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$7@6bbe85a8)]
> 11:01:00,087 WARN [org.apache.activemq.artemis.core.server] AMQ222010:
> Critical IO Error, shutting down the server.
> file=AIOSequentialFile:/home/dbruscin/Workspace/activemq-artemis/tests/integration-tests/./target/tmp/junit9074908614954602801/journal0-L5672/activemq-data-1.amq,
> message=Can't write records (size=2097454) bigger than the
> bufferSize(501760) on the journal: java.lang.IllegalStateException: Can't
> write records (size=2097454) bigger than the bufferSize(501760) on the journal
> at
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer.checkSize(TimedBuffer.java:247)
> [:]
> at
> org.apache.activemq.artemis.core.io.AbstractSequentialFile.fits(AbstractSequentialFile.java:180)
> [:]
> at
> org.apache.activemq.artemis.core.journal.impl.JournalImpl.switchFileIfNecessary(JournalImpl.java:3065)
> [:]
> at
> org.apache.activemq.artemis.core.journal.impl.JournalImpl.appendRecord(JournalImpl.java:2796)
> [:]
> at
> org.apache.activemq.artemis.core.journal.impl.JournalImpl.access$100(JournalImpl.java:91)
> [:]
> at
> org.apache.activemq.artemis.core.journal.impl.JournalImpl$1.run(JournalImpl.java:852)
> [:]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
> [:]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
> [:]
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
> [:]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [rt.jar:1.8.0_212]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [rt.jar:1.8.0_212]
> at
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
> [:]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
