[
https://issues.apache.org/jira/browse/ARTEMIS-2371?focusedWorklogId=256875&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-256875
]
ASF GitHub Bot logged work on ARTEMIS-2371:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/19 14:35
Start Date: 10/Jun/19 14:35
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #2694:
ARTEMIS-2371 Message with huge header shuts broker down
URL: https://github.com/apache/activemq-artemis/pull/2694#discussion_r292037837
##########
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/journal/ActiveMQJournalBundle.java
##########
@@ -47,4 +47,7 @@
@Message(id = 149004, value = "unable to open file")
String unableToOpenFile();
+
+ @Message(id = 149005, value = "Record (size={0}) larger than the store
maxRecordSize({1})", format = Message.Format.MESSAGE_FORMAT)
Review comment:
please, use a more user friendly message... something that would make sense
to an user...
"Your message is storing too much data as part of properties
(maxSize=maxSize). Store large data as part of the MessageBody"
Something like that.. I dunno.. this is just a suggestion.
this is actually the reason I asked you to change the test.. if you ever
change the english grammar, translations.. whateverthe test will be broken.
Test based on the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 256875)
Time Spent: 2h 10m (was: 2h)
> AMQP: message with very large header shuts broker down
> ------------------------------------------------------
>
> Key: ARTEMIS-2371
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2371
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP, Broker
> Affects Versions: 2.9.0
> Reporter: Domenico Bruscino
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> When there is one really large header sent with the message, the broker does
> not have room for it and shuts down. Using an AMQP client send a message with
> an extremely large header (>600000 bytes) and broker default configuration
> this will trigger the following exception:
> {code:java}
> [Thread-0
> (ActiveMQ-IO-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$7@6bbe85a8)]
> 11:01:00,087 WARN [org.apache.activemq.artemis.core.server] AMQ222010:
> Critical IO Error, shutting down the server.
> file=AIOSequentialFile:/home/dbruscin/Workspace/activemq-artemis/tests/integration-tests/./target/tmp/junit9074908614954602801/journal0-L5672/activemq-data-1.amq,
> message=Can't write records (size=2097454) bigger than the
> bufferSize(501760) on the journal: java.lang.IllegalStateException: Can't
> write records (size=2097454) bigger than the bufferSize(501760) on the journal
> at
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer.checkSize(TimedBuffer.java:247)
> [:]
> at
> org.apache.activemq.artemis.core.io.AbstractSequentialFile.fits(AbstractSequentialFile.java:180)
> [:]
> at
> org.apache.activemq.artemis.core.journal.impl.JournalImpl.switchFileIfNecessary(JournalImpl.java:3065)
> [:]
> at
> org.apache.activemq.artemis.core.journal.impl.JournalImpl.appendRecord(JournalImpl.java:2796)
> [:]
> at
> org.apache.activemq.artemis.core.journal.impl.JournalImpl.access$100(JournalImpl.java:91)
> [:]
> at
> org.apache.activemq.artemis.core.journal.impl.JournalImpl$1.run(JournalImpl.java:852)
> [:]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
> [:]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
> [:]
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
> [:]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [rt.jar:1.8.0_212]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [rt.jar:1.8.0_212]
> at
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
> [:]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
