[
https://issues.apache.org/jira/browse/ARTEMIS-2002?focusedWorklogId=262866&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-262866
]
ASF GitHub Bot logged work on ARTEMIS-2002:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jun/19 08:16
Start Date: 19/Jun/19 08:16
Worklog Time Spent: 10m
Work Description: brusdev commented on pull request #2707: ARTEMIS-2002
Proton transport objects leaked
URL: https://github.com/apache/activemq-artemis/pull/2707#discussion_r295172966
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
##########
@@ -183,6 +191,17 @@ public void flush() {
}
public void close(ErrorCondition errorCondition) {
+ synchronized (schedulingLock) {
+ isSchedulingCancelled = true;
+
+ if (scheduledPool != null && scheduledPool instanceof
ThreadPoolExecutor &&
+ scheduledFuture != null && scheduledFuture instanceof Runnable) {
+ if (!((ThreadPoolExecutor) scheduledPool).remove((Runnable)
scheduledFuture)) {
Review comment:
Currently scheduledPool is used by:
1) AMQPConnectionContext more time but one task at once for instance
2) ActiveMQServerImpl one time and one task
3) SharedNothingBackupQuorum one time and one task
4) MessagePullHandler each time AMQConsumer.handleDeliver is called if
prefetchSize = 0
ScheduledPool is mostly used by AMQPConnectionContext (one for each amqp
connection) and remove is called only on connection close, so the effort for
the remove should not impact on the entire system scalability.
Moreover GC should manage that unused objects until they are not removed
from the scheduledPool.
Finally WeakReference require deeper source change for ScheduleRunnable and
TickerRunnable to avoid unpredictable behavior when GC delete
AMQPConnectionContext before their execution.
My concern is that to introduce unpredictable behavior to avoid paying a
small computational cost.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 262866)
Time Spent: 3h 10m (was: 3h)
> Proton transport objects leaked if client disconnects abruptly leading to
> OutOfMemoryError: Java heap space
> -----------------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-2002
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2002
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.6.2
> Reporter: Keith Wall
> Priority: Major
> Attachments: ARTEMIS-2002-OOMEHeap-ProtonObjectsLeaked.png
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> If an AMQP client with an attached receiving link disconnects abruptly (i.e.
> closes socket without sending the AMQP close performative), {{TransportImpl}}
> and other Proton class instances remain referenced within the heap. If many
> such clients do this, an OutOfMemoryError: Java heap space occurs. This
> occurs even though the underlying socket connection has been closed.
> I have reproduced this issue against both 2.6.2 and master
> (f0c13622ac7e821a81a354b0242ef5235b6e82df).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
