[ 
https://issues.apache.org/jira/browse/ARTEMIS-2401?focusedWorklogId=266905&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-266905
 ]

ASF GitHub Bot logged work on ARTEMIS-2401:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Jun/19 18:12
            Start Date: 25/Jun/19 18:12
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on issue #2731: [ARTEMIS-2401]: 
Implement the Pause method for a Topic
URL: https://github.com/apache/activemq-artemis/pull/2731#issuecomment-505557860
 
 
   Since pausing an address is essentially just pausing all of the bound queues 
(i.e. not the actual consumers) I think the method names should reflect that. 
Therefore, I recommend using `pause()`, `resume()`, & `isPaused()`. The 
`AddressControl` should also expose `paused` so users can determine whether or 
not an address is paused administratively.
   
   Also, the commit message doesn't need any square brackets of colons, and it 
should refer to core resources (i.e. "address" instead of "topic").
   
   Lastly, I think you'll want to persist the paused status of the address to 
avoid confusion when an address is paused and the broker is restarted. In this 
case all of the bound queues will still be paused (since queues persist their 
paused status), but when looking at the address administratively or 
programmatically it will appear that it is not paused.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 266905)
    Time Spent: 40m  (was: 0.5h)

> Implement the Pause method for a Topic
> --------------------------------------
>
>                 Key: ARTEMIS-2401
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2401
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>          Components: Broker
>    Affects Versions: 2.9.0
>            Reporter: Emmanuel Hugonnet
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Enable to pause all the consumers of a topic. New subscriptions being 
> registered while the topic is in pause will be paused also.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to