[
https://issues.apache.org/jira/browse/ARTEMIS-2414?focusedWorklogId=272408&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-272408
]
ASF GitHub Bot logged work on ARTEMIS-2414:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jul/19 03:36
Start Date: 05/Jul/19 03:36
Worklog Time Spent: 10m
Work Description: wy96f commented on pull request #2740: ARTEMIS-2414
Sync before closing file in case data loss
URL: https://github.com/apache/activemq-artemis/pull/2740
When we open a new page, the page sync timer might sync the new page, i.e.
the new page and after it responses are sent back to client. For the old page
is closed(not synced), we may lose messages if server crashes before dirty page
cache written back into disk.
When we switch journal file to the new file, TimedBuffer::flushBatch will be
called in the old file. Then the file would be synced except in the case user
sets "journalDatasync" to false. For safety we'd better sync journal file
before closing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 272408)
Time Spent: 10m
Remaining Estimate: 0h
> Sync before closing file in case data loss
> ------------------------------------------
>
> Key: ARTEMIS-2414
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2414
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.9.0
> Reporter: yangwei
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When we open a new page, the page sync timer might sync the new page, i.e.
> the new page and after it responses are sent back to client. For the old page
> is closed(not synced), we may lose messages if server crashes before dirty
> page cache written back into disk.
> When we switch journal file to the new file, TimedBuffer::flushBatch will be
> called in the old file. Then the file would be synced except in the case user
> sets "journalDatasync" to false. For safely we'd better sync journal file
> before closing it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
