[
https://issues.apache.org/jira/browse/AMQNET-589?focusedWorklogId=276056&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-276056
]
ASF GitHub Bot logged work on AMQNET-589:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/19 18:10
Start Date: 12/Jul/19 18:10
Worklog Time Spent: 10m
Work Description: cjwmorgan-sol commented on pull request #4: AMQNET-589:
Failover implementation
URL: https://github.com/apache/activemq-nms-amqp/pull/4#discussion_r303092761
##########
File path: src/NMS.AMQP/SessionDispatcher.cs
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+using System.Threading;
+using System.Threading.Tasks;
+using System.Threading.Tasks.Dataflow;
+
+namespace Apache.NMS.AMQP
+{
+ internal class SessionDispatcher
+ {
+ private readonly ActionBlock<NmsMessageConsumer.MessageDeliveryTask>
actionBlock;
+ private int dispatchThreadId;
+ private readonly CancellationTokenSource cts;
+
+ public SessionDispatcher()
+ {
+ cts = new CancellationTokenSource();
+ actionBlock = new
ActionBlock<NmsMessageConsumer.MessageDeliveryTask>(HandleTask, new
ExecutionDataflowBlockOptions
+ {
+ EnsureOrdered = true,
+ MaxDegreeOfParallelism = 1,
+ CancellationToken = cts.Token
+ });
+ }
+
+ public void Post(NmsMessageConsumer.MessageDeliveryTask task) =>
actionBlock.Post(task);
+
+ public bool IsOnDeliveryThread() => dispatchThreadId ==
Thread.CurrentThread.ManagedThreadId;
+
+ private void HandleTask(NmsMessageConsumer.MessageDeliveryTask
messageDeliveryTask)
+ {
+ try
+ {
+ dispatchThreadId = Thread.CurrentThread.ManagedThreadId;
+ messageDeliveryTask.DeliverNextPending();
+ }
+ finally
+ {
+ dispatchThreadId = -1;
+ }
+ }
+
+ public void Stop()
+ {
+ actionBlock.Complete();
+ cts.Cancel();
Review comment:
>I had to resign from this, in order to implement Session recovery the same
way as it was implemented in qpid jms.
Thanks I missed that, I ran the tests you mentioned and they pass however I
still found some issues involving stop and close and getting message delivery
after stop and close.
See https://github.com/apache/activemq-nms-amqp/pull/4#discussion_r303081996.
I suspect I key aspect of the qpid design for this is missing in the
currently implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 276056)
Time Spent: 2.5h (was: 2h 20m)
> NMS AMQP Failover implementation
> --------------------------------
>
> Key: AMQNET-589
> URL: https://issues.apache.org/jira/browse/AMQNET-589
> Project: ActiveMQ .Net
> Issue Type: Improvement
> Components: ActiveMQ, AMQP, NMS
> Affects Versions: 1.8.0
> Reporter: Krzysztof Porebski
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Implement failover in NMS AMQP the same way as it is implemented in QpidJMS.
> This will involve some major rework, as current design is too rigid to
> introduce this feature.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
