[
https://issues.apache.org/jira/browse/ARTEMIS-2407?focusedWorklogId=277035&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-277035
]
ASF GitHub Bot logged work on ARTEMIS-2407:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/19 22:40
Start Date: 15/Jul/19 22:40
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #2738:
ARTEMIS-2407 Large message file not deleted if broker crashes between page
deleted and pending large message written
URL: https://github.com/apache/activemq-artemis/pull/2738#discussion_r303666042
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java
##########
@@ -352,11 +353,15 @@ public boolean delete(final PagedMessage[] messages)
throws Exception {
// Because the large-message may be linked to another message
// or it may still being delivered even though it has been
acked already
lmsg.decrementDelayDeletionCount();
+ largeMessageIds.add(lmsg.getMessageID());
}
}
}
try {
+ if (!storageManager.getContext().waitCompletion(5000)) {
+ logger.info("Time out waiting for large messages" +
largeMessageIds + ", may be not deleted if crashed");
Review comment:
please create a paramatised logger with a log code,
ActiveMQServerLogger.LOGGER
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 277035)
Time Spent: 20m (was: 10m)
> Large message file not deleted if broker crashes between page deleted and
> pending large message written
> -------------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-2407
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2407
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.9.0
> Reporter: yangwei
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In paging mode, when the broker crashes between page file is deleted and
> pending large message is written into disk, the large message file would
> never be deleted after startup.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
