[
https://issues.apache.org/jira/browse/ARTEMIS-2420?focusedWorklogId=279335&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279335
]
ASF GitHub Bot logged work on ARTEMIS-2420:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/19 21:00
Start Date: 18/Jul/19 21:00
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #2760:
ARTEMIS-2420 Adding support for DLA/DLQ prefix for wildcard addresses
URL: https://github.com/apache/activemq-artemis/pull/2760#discussion_r305110265
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
##########
@@ -2635,6 +2635,9 @@ public String getAddressSettingsAsJSON(final String
address) throws Exception {
if (addressSettings.getDeadLetterAddress() != null) {
settings.add("DLA",
addressSettings.getDeadLetterAddress().toString());
}
+ if (addressSettings.getDeadLetterAddressPrefix() != null) {
+ settings.add("DLAPrefix",
addressSettings.getDeadLetterAddressPrefix().toString());
Review comment:
Should we avoid proliferating acronymn and use deadLetterAddressPrefix
instead. Similar to expiryAddress. Is then clearer going forwards
And in line with xml based configuration which isnt acronymd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 279335)
Time Spent: 6h 10m (was: 6h)
Remaining Estimate: 5h 50m (was: 6h)
> Reimplementation of AMQ5 dead letter strategy queuePrefix
> ---------------------------------------------------------
>
> Key: ARTEMIS-2420
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2420
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.9.0
> Reporter: Piotr Klimczak
> Priority: Major
> Original Estimate: 12h
> Time Spent: 6h 10m
> Remaining Estimate: 5h 50m
>
> ActiveMQ Classic supports DLQ prefixes for dynamically created destinations.
> This causes regression when switching from AMQ5 to AMQ Artemis, therefore it
> should be reimplemented.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
