[
https://issues.apache.org/jira/browse/ARTEMIS-2415?focusedWorklogId=280090&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-280090
]
ASF GitHub Bot logged work on ARTEMIS-2415:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jul/19 12:57
Start Date: 20/Jul/19 12:57
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #2741:
ARTEMIS-2415 JDBCJournal miss pending tasks during shutdown
URL: https://github.com/apache/activemq-artemis/pull/2741#discussion_r305579463
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
##########
@@ -268,6 +271,8 @@ private boolean internalStop(boolean ioCriticalError,
boolean sendFailover) thro
idGenerator.persistCurrentID();
}
+ deletingLargeMessageTasks.await(30, TimeUnit.SECONDS);
Review comment:
that doesnt mean its something we would want to proliferate. Just because a
window is broken already, doesnt mean its ok to just go inside... avoid the
broken glass... be a good citizen tidy up the glass, report it to the police,
fix the window.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 280090)
Time Spent: 2h 40m (was: 2.5h)
> JDBCJournal miss pending tasks during shutdown
> ----------------------------------------------
>
> Key: ARTEMIS-2415
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2415
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Domenico Bruscino
> Priority: Major
> Attachments:
> downstream_run_16.filtered_testRegularMessagePersistenceDelayedConsumer.log
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> If server stops while having pending tasks in OperationContextImpl for
> JDBCJournal, server omits this tasks and prints a bunch of exceptions in the
> log, not exiting cleanly.
> Log of the situation from the test run is attached.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
