[
https://issues.apache.org/jira/browse/ARTEMIS-2420?focusedWorklogId=280130&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-280130
]
ASF GitHub Bot logged work on ARTEMIS-2420:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jul/19 20:54
Start Date: 20/Jul/19 20:54
Worklog Time Spent: 10m
Work Description: PiotrKlimczak commented on pull request #2760:
ARTEMIS-2420 Adding support for DLA/DLQ prefix for wildcard addresses
URL: https://github.com/apache/activemq-artemis/pull/2760#discussion_r305592844
##########
File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
##########
@@ -2939,6 +2939,13 @@
</xsd:documentation>
</xsd:annotation>
</xsd:element>
+ <xsd:element maxOccurs="1" minOccurs="0"
name="dead-letter-address-prefix" type="xsd:string">
Review comment:
I have checked git history, unfortunately, it goes back to 2014.
I can change it to sequence, as long as we are happy to accept regression
caused and expectation from users to change their configs.
My personal feeling is that it is not worth it, as instead, I can implement
that in java, giving the same effect but not affecting users.
I am happy however to follow your guidance if you think that is best for the
project.
Please let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 280130)
Time Spent: 10h 10m (was: 10h)
Remaining Estimate: 1h 50m (was: 2h)
> Reimplementation of AMQ5 dead letter strategy queuePrefix
> ---------------------------------------------------------
>
> Key: ARTEMIS-2420
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2420
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.9.0
> Reporter: Piotr Klimczak
> Priority: Major
> Original Estimate: 12h
> Time Spent: 10h 10m
> Remaining Estimate: 1h 50m
>
> ActiveMQ Classic supports DLQ prefixes for dynamically created destinations.
> This causes regression when switching from AMQ5 to AMQ Artemis, therefore it
> should be reimplemented.
> *Detailed requirements*
> *Configuration*
> # Prefix for dead-letter-address-auto-create is mandatory, while the tag
> itself is optional
> # All attributes for dead-letter-address-auto-create are optional, in which
> case values will be taken from origin queue
> ** routing type for DLQ
> ** temporary
> ** durable can be null
> # DLA settings can be defined with address-settings with wildcard match
> # Should throw error if both DLA and auto-create DLA are defined for same AS
> - *TODO*
> Example
> {code:xml}
> <address-setting match="#">
> <dead-letter-address-auto-create prefix="DLA.">
> <routing-type>MULTICAST</routing-type>
> <durable>true</durable>
> <temporary>false</temporary>
> </dead-letter-address-auto-create>
> </address-setting>
> <address-setting match="DLA.#">
> <!-- DLA config goes here, as for standard addresses -->
> </address-setting>
> {code}
> Questions:
> # [michaelpearce-gain|https://github.com/michaelpearce-gain]: What occurs if
> both dead letter address is set and prefix?
> # [michaelpearce-gain|https://github.com/michaelpearce-gain]: Is there auto
> clean up, so the auto created dead letter addresses are removed when the
> original address is removed, in cases of auto creation.
> # [michaelpearce-gain|https://github.com/michaelpearce-gain]: Also would it
> be possible to configure a spefiic queue to goto a specific address, taking
> precedence over the default prefix when set.
> ** This is how it should work now- *TODO* test coverage
> *Message delivery to DLQ*
> # Delivery to dynamic DLQ only happens for messages failed by a consumer.
> # Delivery to dynamic addresses should happen using FQQN address, regardless
> of routing.
> # [michaelpearce-gain|https://github.com/michaelpearce-gain]: The same
> should be made for expiryQueues with all the same rules and logic - *TODO*
> Questions:
> # Should dynamic DLQ creation also work for messages delivered to an address
> with no queues?
> *Security*
> # TODO Consolidate security requirements from original PR:
> [https://github.com/apache/activemq-artemis/pull/2747]
>
> Questions:
> # [michaelpearce-gain|https://github.com/michaelpearce-gain]: What occurs if
> queue/address is allowed to be created due security settings, but the user
> able to do that is unable to create the dead letter address? Do both fail?
> Does one part succeed but the dla fails? And then what occurs?
> # [michaelpearce-gain|https://github.com/michaelpearce-gain]: What occurs
> when security settings come into play? How does it fail if you have ability
> to create address but not dla? Do both fail?
>
> Links to all conversations:
> * [https://github.com/apache/activemq-artemis/pull/2760]
> * [https://github.com/clebertsuconic/activemq-artemis/pull/29]
> * [https://github.com/apache/activemq-artemis/pull/2747]
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
