[
https://issues.apache.org/jira/browse/ARTEMIS-2429?focusedWorklogId=280350&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-280350
]
ASF GitHub Bot logged work on ARTEMIS-2429:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/19 11:53
Start Date: 22/Jul/19 11:53
Worklog Time Spent: 10m
Work Description: jdanekrh commented on pull request #2763: ARTEMIS-2429
Fix order of arguments to registerQueueGauge and two related typos
URL: https://github.com/apache/activemq-artemis/pull/2763
Test is also adjusted to test for the changes made.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 280350)
Time Spent: 10m
Remaining Estimate: 0h
> Swapped arguments to registerQueueGauge cause wrong tags on metrics
> -------------------------------------------------------------------
>
> Key: ARTEMIS-2429
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2429
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.9.0
> Reporter: Jiri Daněk
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {noformat}
> *** CID 1483198: API usage errors (SWAPPED_ARGUMENTS)
> /activemq-artemis/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
> 3872 in
> org.apache.activemq.artemis.core.server.impl.QueueImpl.registerMeters()()
> 3866 String addressName = address.toString();
> 3867 String queueName = name.toString();
> 3868
> 3869 if (server != null && server.getMetricsManager() != null) {
> 3870 MetricsManager metricsManager = server.getMetricsManager();
> 3871
> >>> CID 1483198: API usage errors (SWAPPED_ARGUMENTS)
> >>> The positions of arguments in the call to "registerQueueGauge" do not
> >>> match the ordering of the parameters:
> * "queueName" is passed to "address"
> * "addressName" is passed to "queue"
> 3872 metricsManager.registerQueueGauge(queueName, addressName,
> (builder) -> {
> 3873 builder.register(QueueMetricNames.MESSAGE_COUNT,
> pendingMetrics, metrics -> Double.valueOf(pendingMetrics.getMessageCount()),
> QueueControl.MESSAGE_COUNT_DESCRIPTION);
> 3874 builder.register(QueueMetricNames.DURABLE_MESSAGE_COUNT,
> pendingMetrics, metrics ->
> Double.valueOf(pendingMetrics.getDurableMessageCount()),
> QueueControl.DURABLE_MESSAGE_COUNT_DESCRIPTION);
> 3875 builder.register(QueueMetricNames.PERSISTENT_SIZE,
> pendingMetrics, metrics ->
> Double.valueOf(pendingMetrics.getPersistentSize()),
> QueueControl.PERSISTENT_SIZE_DESCRIPTION);
> 3876
> builder.register(QueueMetricNames.DURABLE_PERSISTENT_SIZE, pendingMetrics,
> metrics -> Double.valueOf(pendingMetrics.getDurablePersistentSize()),
> QueueControl.DURABLE_PERSISTENT_SIZE_DESCRIPTION);
> 3877
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
